-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpl2: IOs abstraction adaptation to ORFS flow - first version (simplified) #5809
base: master
Are you sure you want to change the base?
mpl2: IOs abstraction adaptation to ORFS flow - first version (simplified) #5809
Conversation
Signed-off-by: Arthur Koucher <[email protected]>
1) Remove logic of bundled ios per edge and add one constraint cluster per edge 2) Add checks to prevent crash - for testing 3) Comment blockages creation based on IO placement Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
1) map bterms when creating a new io cluster 2) remove debug check 3) cluster that represent no constraints have the shape of the die Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…d SA Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
1) avoid computing WL twice for IO cases 2) add fixed penalty for IO connections when the macro is outside the outline 3) don't draw dist to edge in graphics when macro is outside the outline Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…t boundary is blocked Signed-off-by: Arthur Koucher <[email protected]>
…ed to NONE Signed-off-by: Arthur Koucher <[email protected]>
…cked Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
… area and io clusters' extensions Signed-off-by: Arthur Koucher <[email protected]>
…blockages Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
Conflict to resolve |
Signed-off-by: Arthur Koucher <[email protected]>
Resolved. |
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Some unit test need fixing:
|
It would be good to merge master and do a fresh secure CI as this PR is a bit old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending updated secure CI.
I ran an updated Secure-CI in the weekend and the only concerning thing is a WL degradation in gf180/uartblocks: gf180 uart-blocks I'll investigate it. |
1) make pin access blockage creation more succinct 2) update regression tests with PPL updates 3) draw x mark on top of macros in debug (and erase it at the end) Signed-off-by: Arthur Koucher <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Arthur Koucher <[email protected]>
Signed-off-by: Arthur Koucher <[email protected]>
…ovement Signed-off-by: Arthur Koucher <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
The problem with uart-blocks was due to the fact that I wasn't considering the case in which a pin was not constrained to any region in the orientation improvement step. Now we compute WL with a similar technique used in SA: we get the closest point in the closest boundary and merge it's rect in the net_box. I'm including this in the PR description for documentation. Also: |
I'm running a new secure-CI with my latest changes and master. |
Secure-CI is fine. There a couple designs that need metrics update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have further comments, but I'll wait for @maliberty's final review before merging.
Is there a PR for this? |
I opened #2582. However, a metrics conflict emerged from another PR. I'm re-running Secure-CI to update the metrics correctly. |
Resolve the first top level task in #5669.
Close #4867.
Introductory Considerations
Goals
Main Changes
Modify IO Clusters
IO clusters that represent bundledIOs created from the pins placed by random PPL are now groups of unplaced IOs with the same constraints based on the following:
Individual Pin Constraints:
Global Pins' Constraints (-exclude)
What Annealing Sees
Obs: This distance only reduces cost when M is inside the outline.
Collateral Changes
Needed for the Approach to Work
Blockages for Pin Access
Generated based on a combination of both global and individual pins' constraints:
Orientation Improvement
When iterating a net, compute HPWL based on:
Debug Mode