Skip to content

Commit

Permalink
ifp: Address -row_parity review comments
Browse files Browse the repository at this point in the history
Signed-off-by: gatecat <[email protected]>
  • Loading branch information
gatecat committed Jul 26, 2024
1 parent 8cba2f8 commit 9af9c0b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/ifp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ initialize_floorplan
| `-site` | Site name. |
| `-die_area` | Die area coordinates in microns (lower left x/y and upper right x/y coordinates). |
| `-core_area` | Core area coordinates in microns (lower left x/y and upper right x/y coordinates). |
| `-row_parity` | Snap to either an odd (`ODD`) or even (`EVEN`) number of rows. |
| `-row_parity` | Snap to either an odd (`ODD`) or even (`EVEN`) number of rows. Defaults to `NONE` (no constraint on parity). |

### Make Tracks

Expand Down
2 changes: 1 addition & 1 deletion src/ifp/src/InitFloorplan.cc
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ void InitFloorplan::makeUniformRows(odb::dbSite* base_site,
break;
case RowParity::ODD:
if (rows_y > 0) {
rows_y = ((rows_y - 1) / 2) * 2 + 1;
rows_y = (rows_y % 2 == 0) ? rows_y - 1 : rows_y;
} else {
rows_y = 0;
}
Expand Down
4 changes: 2 additions & 2 deletions src/ifp/src/InitFloorplan.i
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ init_floorplan_core(int die_lx,
int core_uy,
odb::dbSite* site,
const std::vector<odb::dbSite*>& additional_sites,
ifp::RowParity row_parity)
ifp::RowParity row_parity)
{
get_floorplan().initFloorplan({die_lx, die_ly, die_ux, die_uy},
{core_lx, core_ly, core_ux, core_uy},
Expand All @@ -127,7 +127,7 @@ init_floorplan_util(double util,
int core_space_right,
odb::dbSite* site,
const std::vector<odb::dbSite*>& additional_sites,
ifp::RowParity row_parity)
ifp::RowParity row_parity)
{
get_floorplan().initFloorplan(util, aspect_ratio,
core_space_bottom, core_space_top,
Expand Down
2 changes: 1 addition & 1 deletion src/ifp/src/InitFloorplan.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ sta::define_cmd_args "initialize_floorplan" {[-utilization util]\
[-core_area {lx ly ux uy}]\
[-additional_sites site_names]\
[-site site_name]\
[-row_parity NONE|ODD|EVEN]}
[-row_parity NONE|ODD|EVEN]}

proc initialize_floorplan { args } {
sta::parse_key_args "initialize_floorplan" args \
Expand Down

0 comments on commit 9af9c0b

Please sign in to comment.