-
Notifications
You must be signed in to change notification settings - Fork 411
Add TensorBoard logging for AutoTuner sweep mode #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Introduced `TensorBoardLogger` class for logging metrics during sweeps. * Updated `sweep` function to integrate TensorBoard logging. * Enhanced `consumer` function to log metrics after each parameter run. Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
|
@jeffng-or Back-ported the feature, could you please checkout this branch and let me know if it works? |
Great, thanks! I will check it out and let you know how it goes. |
|
It looks like the code is trying to write the SDC file into tools/AutoTuner/src/constraint.sdc, which isn't writable and also not in a trial-specific directory: I'm running within a docker container where I've mounted the tools/AutoTuner/src/autotuner directory, but not tools/AutoTuner/src. So, the src directory is not writable. Here's the script that I use to start the container: Here's the Dockerfile that I used to build the autotuner:1.0 container: To build the docker image: To start the container: Within the container: |
vvbandeira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luarss
Please address Jeff's concerns and request a new review when he is satisfied.
|
So, here are some differences that I see between tune and sweep:
Maybe we should be writing the SDC file under the experiment directory, which would be under flow/logs? At least we'd know that the directory is writable. After I make the change, the AT starts running trials. As it's running, I'm noticing the following:
|
|
The job ran overnight without completing, so there's something off. Please use the following flow for testing:
autotuner.json Once it works for you, I can try again. |
TensorBoardLoggerclass for logging metrics during sweeps.sweepfunction to integrate TensorBoard logging.consumerfunction to log metrics after each parameter run.