Fix the scope used by log_cmd #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uplevel is needed as otherwise the variables set the script are in the scope of log_cmd's proc and not the callers. This problem was hidden by sta's overriding of source but now that it is removed the problem manifests. Signed-off-by: Matt Liberty <[email protected]>
maliberty
approved these changes
Apr 16, 2025
oharboe
approved these changes
Apr 16, 2025
| puts $log_cmd | ||
| set start [clock seconds] | ||
| $cmd {*}$args | ||
| uplevel 1 [list $cmd {*}$args] |
Collaborator
There was a problem hiding this comment.
Nice! I had to read line 6 twice before I realized it was a concatenation, but either is idiomatic tcl:
uplevel 1 [concat [list $cmd] $args]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uplevel is needed as otherwise the variables set the script are in the scope of log_cmd's proc and not the callers. This problem was hidden by sta's overriding of source but now that it is removed the problem manifests.