Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repackage output to crate form #11

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Repackage output to crate form #11

merged 4 commits into from
Jan 16, 2024

Conversation

ByteOtter
Copy link
Member

@ByteOtter ByteOtter commented Jan 15, 2024 •
edited
Loading

What does this PR change?

Will repackage the output into a Rust crate format.

Todo:

  • Make dependency version types dynamic (currently copied from Thanix)
  • Allow user to specify library name

Tick the applicable box:

  • Add new feature
  • Security changes
  • Tests
  • Documentation changed

  • General Maintenance

Links

Fixes: N/A

  • DONE

Documentation

  • No documentation needed

  • DONE

@ByteOtter ByteOtter requested a review from marv7000 January 15, 2024 20:32
@ByteOtter ByteOtter marked this pull request as draft January 15, 2024 20:36
@ByteOtter ByteOtter force-pushed the dev/repackage-to-lib branch from e5f8b3d to d4d1800 Compare January 16, 2024 08:58
@ByteOtter ByteOtter force-pushed the dev/repackage-to-lib branch from d4d1800 to 9cc230b Compare January 16, 2024 11:00
@ByteOtter ByteOtter force-pushed the dev/repackage-to-lib branch from 53ebfb5 to b84a070 Compare January 16, 2024 13:18
@ByteOtter ByteOtter marked this pull request as ready for review January 16, 2024 13:31
marv7000
marv7000 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@marv7000 marv7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ByteOtter ByteOtter merged commit 8100785 into The-Nazara-Project:main Jan 16, 2024
4 checks passed
@ByteOtter ByteOtter deleted the dev/repackage-to-lib branch January 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marv7000 marv7000 marv7000 approved these changes

Assignees
No one assigned
Labels
dependencies rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByteOtter @marv7000