Update build process to include dependencies installation and app build

Thavarshan · Sep 2, 2024 · e03bffa · e03bffa
1 parent 2b9ab88
commit e03bffa
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
@@ -56,6 +56,15 @@ jobs:
         CERT_PASSWORD: ${{ env.CERT_PASSWORD }}
       shell: pwsh
 
+    - name: Install dependencies
+      run: npm install
+
+    - name: Build app
+      run: npm run make
+      env:
+        WINDOWS_KIT_PATH: ${{ env.WINDOWS_KIT_PATH }}
+      shell: pwsh
+
     - name: Extract version from package.json
       run: |
         $version = (node -e "console.log(require('./package.json').version);")

diff --git a/forge.config.ts b/forge.config.ts
@@ -8,6 +8,9 @@ import path from 'node:path';
 const { version } = packageJson;
 const iconDir = path.resolve(__dirname, 'src', 'assets', 'images', 'icons');
 
+console.log('CERT_PATH', process.env.CERT_PATH);
+console.log('CERT_PASSWORD', process.env.CERT_PASSWORD);
+
 const commonLinuxConfig = {
   name: 'comet',
   productName: 'Comet',
@@ -50,14 +53,10 @@ const config: ForgeConfig = {
         packageDescription: 'A simple video converter',
         packageVersion: `${version}.1`,
         publisher: 'CN=E0D72A6F-3D67-49D6-9EA4-99FAFB4620E5',
-        devCert: process.env.CERT_PATH,
-        certPass: process.env.CERT_PASSWORD,
+        devCert: path.resolve(__dirname, 'tools/certs/dev-cert.pfx'),
+        certPass: 'alpha26!',
         windowsKit: process.env.WINDOWS_KIT_PATH,
-        icon: path.resolve(iconDir, 'icon.ico'),
-        makeVersionWinStoreCompatible: true,
-        signtoolParams: [
-          '/v',
-        ]
+        icon: path.resolve(iconDir, 'icon.ico')
       },
     },
     {

diff --git a/tools/certs/dev-cert.pfx b/tools/certs/dev-cert.pfx