Bypass code signing for now

Thavarshan · Aug 17, 2024 · 42a1b94 · 42a1b94
1 parent 75c175d
commit 42a1b94
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -46,7 +46,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
         with:
           tag_name: ${{ github.ref }}
-          release_name: Release ${{ github.ref }}
+          release_name: ${{ github.ref }}
           draft: false
           prerelease: false
 

diff --git a/forge.config.ts b/forge.config.ts
@@ -16,14 +16,15 @@ const config: ForgeConfig = {
     icon: process.platform === 'win32' ? 'src/assets/images/icon/icon.ico' : 'src/assets/images/icon/icon.icns',
     executableName: 'comet',
     extraResource: 'node_modules/ffmpeg-static/ffmpeg',
-    ...(process.platform === 'darwin' && {
-      osxSign: {},
-      osxNotarize: {
-        appleId: process.env.APPLE_ID,
-        appleIdPassword: process.env.APPLE_ID_PASSWORD,
-        teamId: process.env.TEAM_ID,
-      },
-    }),
+    // Bypassing the sigining and notarisation for now
+    // ...(process.platform === 'darwin' && {
+    //   osxSign: {},
+    //   osxNotarize: {
+    //     appleId: process.env.APPLE_ID,
+    //     appleIdPassword: process.env.APPLE_ID_PASSWORD,
+    //     teamId: process.env.TEAM_ID,
+    //   },
+    // }),
   },
   rebuildConfig: {},
   makers: [