Clean out NSNulls in removedSubnodes list (fixes #2059) #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2059.
Starting Swift 5.6 (Xcode 13.3), I'm seeing
NSNulls populating the_removedSubnodeslist and causingunrecognized selectorcrashes. I'm not sure where this is coming from because it only occurs in Release builds which makes debugging really hard, but I have confirmed this PR to fix the issue.One reproducible event for me that triggers this crash is during device rotation where
layoutSpecThatFitsrecompute the layouts. It's not an isolated case either because I see it in most screens.If anyone can provide a better fix, please suggest.