Select constrain #5270
Merged
Select constrain #5270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
approved these changes
Nov 21, 2024
Member
darrenburns
left a comment
darrenburns
left a comment
There was a problem hiding this comment.
Tested it out in Posting and looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the constrain wasn't applied to the Select. This ensures that if you expand the select when it is at the bottom of the screen, it will always be visible. See snapshot if that isn't clear.
Also may have fixed the erratic invisible select issue. The OptionList updates caches on idle, these caches influence the height returned by
get_content_height. So the auto height returned may not reflect the actual items, depending on when idle events are generated.If Select issue is fixed (still not certain), I can at least postpone the OptionList refactor.