Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
I was looking for a generic speed column for
Progress
preferably with customizable units. I only found #926, which hinted atTransferSpeedColumn
being a good example, but did not have a resolution.This PR adds
SpeedColumn
, which may be used like this:I reuse
TaskProgressColumn.render_speed
for consistency and extended bothTaskProgressColumn.render_speed
andTaskProgressColumn
itself to also accept custom units.Regarding the unit tests, I added a line mimicking the test for
TransferSpeedColumn
as well as extendingtest_task_progress_column_speed
to testTaskProgressColumn.render_speed
with customunits
. Is there more desired here?I believe, I also fixed a documentation bug in
TaskProgressColumn.render_speed
, which referred to:task (Task): A Task object.
as argument, where it should have been:
speed (float): Current value of the speed.