Fix standby sequence and add Debugss LPSC#72
Open
ti-scaria wants to merge 3 commits intoTexasInstruments:ti-masterfrom
Open
Fix standby sequence and add Debugss LPSC#72ti-scaria wants to merge 3 commits intoTexasInstruments:ti-masterfrom
ti-scaria wants to merge 3 commits intoTexasInstruments:ti-masterfrom
Conversation
Due to an earlier implementation the lpsc_value array was indexed using the lpsc_id. Later, the indexing was changed to the loop variable which was not reflected in the restore and standby sequence. Also updated the magic numbers used in LPSC state change with defined macros. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
This commit adds the support to disable the DEBUGSS LPSC in the low latency standby sequence. The PLL associated with DEBUGSS should be disabled after the LPSC is disabled, thus need to reorder the LPSC and PLL changes in the standby sequence, and in accordance reordering the restore sequence. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
Author
|
Using the kernel : https://github.com/ti-scaria/ti-linux-kernel/tree/s2idle_standby. |
Earlier it was decided to not bring DDR out of auto self refresh in the resume sequence of low latency standby mode. However, this causes a bug in the Deepsleep LPM in the turning off of the DDR LPSCs. Thus restoring the original state of DDR in the resume sequence. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the incorrect indexing of the lpsc_value array introduced in the standby flow.
Adding DEUBGSS LPSC in the list of LPSCs to be disabled in the low latency standby sequence to meet the
requirements provided. Refactoring the code for allowing the above change to work.