Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion packages/components/menu/__tests__/head-menu.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { mount } from '@vue/test-utils';
import { HeadMenu } from '@tdesign/components/menu';
import { defineComponent } from 'vue';
import { HeadMenu, MenuItem } from '@tdesign/components/menu';

// every component needs four parts: props/events/slots/functions.
describe('HeadMenu', () => {
Expand Down Expand Up @@ -52,4 +53,41 @@ describe('HeadMenu', () => {
expect(wrapper.element).toMatchSnapshot();
});
});

describe('JSX rendering', () => {
it('should not warn about slot invoked outside of render function when using JSX with dynamic MenuItems', () => {
const warnSpy = vi.spyOn(console, 'warn');
const menuOptions = [
{ label: '用户信息', key: 'info' },
{ label: '身份验证', key: 'security' },
];

const MenuComponent = defineComponent({
setup() {
return () => (
<HeadMenu>
{menuOptions.map((menu) => (
<MenuItem key={menu.key} value={menu.key}>
{menu.label}
</MenuItem>
))}
</HeadMenu>
);
},
});

const wrapper = mount(MenuComponent);
expect(wrapper.exists()).toBe(true);

// Check that no warning about slot invoked outside of render function was logged
const slotWarnings = warnSpy.mock.calls.filter((call) =>
call.some(
(arg) => typeof arg === 'string' && arg.includes('Slot "default" invoked outside of the render function'),
),
);
expect(slotWarnings.length).toBe(0);

warnSpy.mockRestore();
});
});
});
2 changes: 1 addition & 1 deletion packages/components/menu/head-menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ export default defineComponent({
}
});
};
initVMenu(ctx.slots.default?.() || ctx.slots.content?.() || []);

return () => {
const logo = props.logo?.(h) || ctx.slots.logo?.();
Expand All @@ -241,6 +240,7 @@ export default defineComponent({
// TODO: 判断逻辑不够完善 影响封装组件的子菜单样式渲染 暂时先不执行 待调整实现方案
// const content = formatContent();
const content = ctx.slots.default?.() || ctx.slots.content?.() || [];
initVMenu(content);

return (
<div class={menuClass.value}>
Expand Down
Loading