Skip to content

fix(image-viewer): clean up animation timer on unmount to prevent unhandled errors during test runs #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: develop
Choose a base branch
from
+12 −1
Open

fix(image-viewer): clean up animation timer on unmount to prevent unhandled errors during test runs #6203

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02d8bce
Initial plan
Copilot Nov 28, 2025
e2cde96
fix: clean up animation timer in ImageViewer on unmount to prevent un…
Copilot Nov 28, 2025
51cd941
chore: stash changelog [ci skip]
tdesign-bot Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/components/image-viewer/image-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { BrowseIcon, ChevronDownIcon, ChevronLeftIcon, CloseIcon } from 'tdesign-icons-vue-next';
import { Teleport, Transition, computed, defineComponent, nextTick, ref, toRefs, watch } from 'vue';
import { Teleport, Transition, computed, defineComponent, nextTick, onBeforeUnmount, ref, toRefs, watch } from 'vue';

import {
useVModel,
Expand Down Expand Up @@ -160,6 +160,11 @@ export default defineComponent({
},
);

// Clean up timer when component is unmounted to prevent memory leaks and errors
onBeforeUnmount(() => {
clearTimeout(animationTimer.value);
});

const onWheel = (e: WheelEvent) => {
e.preventDefault();
const { deltaY } = e;
Expand Down
Loading