Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): optimize select-all logic to handle disabled options #4947

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

msg-fobbit
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#4937

💡 需求背景和解决方案

需求背景

Select 组件的全选逻辑存在问题:

  • 当点击“全选”时,已经选中的 disabled 选项会被错误地取消选中。
  • 期望 disabled 选项的选中状态应该完全独立于“全选”操作,无论是否全选, disabled 选项的选中状态都应保持不变。

解决方案

  • 优化全选逻辑,额外处理 disabled 选项,确保 disabled 选项的选中状态不受“全选”操作的影响。

📝 更新日志

  • fix(select): optimize select-all logic to handle disabled options

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Jan 21, 2025

完成

@uyarn uyarn merged commit 57d4b92 into Tencent:develop Jan 22, 2025
7 checks passed
@uyarn
Copy link
Collaborator

uyarn commented Jan 22, 2025

有空可以补个单测

@github-actions github-actions bot mentioned this pull request Jan 24, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants