-
Notifications
You must be signed in to change notification settings - Fork 360
fix(Table): affix width not correct #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RylanBot
wants to merge
7
commits into
develop
Choose a base branch
from
rylan/fix/table/bar
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+290
−180
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
633d1d8
fix(Table): determine affix header width
RylanBot ab6efa1
fix(Table): animation and resize
RylanBot 952dee1
fix(Table): horizontalScrollAffixedBottom
RylanBot 3ccc68a
fix(useAffix): scroll container
RylanBot 96e6638
fix: affix
RylanBot 8707f69
fix(Affix): container
RylanBot 7d50ad5
chore: optimize
RylanBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,19 @@ | ||
| import React, { useState } from 'react'; | ||
| import { Affix, Button } from 'tdesign-react'; | ||
|
|
||
| import type { AffixProps } from 'tdesign-react'; | ||
|
|
||
| export default function BaseExample() { | ||
| const [top, setTop] = useState(150); | ||
| const [affixed, setAffixed] = useState(false); | ||
|
|
||
| const handleClick = () => { | ||
| setTop(top + 10); | ||
| const handleFixedChange: AffixProps['onFixedChange'] = (affixed, { top }) => { | ||
| console.log('top', top); | ||
| setAffixed(affixed); | ||
| }; | ||
|
|
||
| return ( | ||
| <Affix offsetTop={top} offsetBottom={10}> | ||
| <Button onClick={handleClick}>固钉</Button> | ||
| <Affix offsetTop={150} zIndex={2000} onFixedChange={handleFixedChange}> | ||
| <Button theme={affixed ? 'success' : 'primary'}>Affixed: {`${affixed}`}</Button> | ||
| </Affix> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ style | Object | - | 样式,TS 类型:`React.CSSProperties` | N | |
| children | TNode | - | 内容,同 content。TS 类型:`string \| TNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/packages/components/common.ts) | N | ||
| container | String / Function | () => (() => window) | 指定滚动的容器。数据类型为 String 时,会被当作选择器处理,进行节点查询。示例:'body' 或 () => document.body。TS 类型:`ScrollContainer`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/packages/components/common.ts) | N | ||
| content | TNode | - | 内容。TS 类型:`string \| TNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/packages/components/common.ts) | N | ||
| offsetBottom | Number | 0 | 距离容器顶部达到指定距离后触发固定 | N | ||
| offsetBottom | Number | - | 距离容器顶部达到指定距离后触发固定 | N | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| offsetTop | Number | 0 | 距离容器底部达到指定距离后触发固定 | N | ||
| zIndex | Number | - | 固钉定位层级,样式默认为 500 | N | ||
| onFixedChange | Function | | TS 类型:`(affixed: boolean, context: { top: number }) => void`<br/>固定状态发生变化时触发 | N | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
监听
window直接交给组件库内部处理更合理吧...