Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-provider): computed globalConfig reactivity #1670

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Rococoscarlet
Copy link

@Rococoscarlet Rococoscarlet commented Dec 3, 2024

globalconfig响应式行为不起效,只有组件重新渲染后数据才更新。

参考web端仓库pr
fix(config-provider): computed globalConfig reactivity #4612
config-provider的响应式丢失。

mobile端为同样问题

const defaultData = cloneDeep(defaultGlobalConfig);
const mergedGlobalConfig = computed(() => mergeWith(defaultData, props.globalConfig));
provide(configProviderInjectKey, mergedGlobalConfig);

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix(config-provider): computed globalConfig reactivity #4612

💡 需求背景和解决方案

globalconfig响应式行为不起效。

仓库内修改

-const mergedGlobalConfig = computed(() => mergeWith(defaultData, props.globalConfig)); ,
+const mergedGlobalConfig = computed(() => ({ ...mergeWith(defaultData, props.globalConfig) }));

修改后响应式行为正常。

📝 更新日志

fix(ConfigProvider): 修复全局配置丢失响应式问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Dec 3, 2024

完成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants