Fix 3D viewer not loading due to HTML path issue in gradio_app.py #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small patch fixes a logical error in gradio_app.py, causing the generated HTML to contain the filepath relative to app root rather than relative to /static/. Before the patch, the generated `iframe_tag` would contain incorrect references such as `/static/./gradio_cache/5/white_mesh.html`. This fix uses `os.path.relpath()` to strip `SAVE_DIR` from the prefix, thus giving the correct path relative to the static cache directory, ex: `/static/5/white_mesh.html`
YanWenKun
added a commit
to YanWenKun/Hunyuan3D-2
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch fixes a logical error in gradio_app.py, causing the generated HTML to contain the filepath relative to app root rather than relative to the served
/static/directory. Before the patch, the generatediframe_tagwould contain incorrect references such as/static/./gradio_cache/5/white_mesh.html.This fix uses
os.path.relpath()to stripSAVE_DIRfrom the prefix, thus giving the correct path relative to the static cache directory, ex:/static/5/white_mesh.html