Skip to content

Conversation

T-Thiry
Copy link

@T-Thiry T-Thiry commented May 18, 2025

T-Thiry and others added 30 commits May 9, 2025 12:41
@T-Thiry T-Thiry changed the title Portfolio Project - Tavan Thiry Portfolio - Tavan Thiry May 18, 2025
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link

@DevByRico DevByRico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, i have reviewed your portfolio now!

Couldn't find much to be picky on haha, really really great job I must say, clean and good looking portfolio, easy to follow and read, and a consistency in your code.

Well done! 🎉

Comment on lines +12 to +18
<NavLink href="#aboutme">About Me</NavLink>
</NavItem>
<NavItem>
<NavLink href="#projects">Projects</NavLink>
</NavItem>
<NavItem>
<NavLink href="#contact">Contact</NavLink>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navbar links "About Me", "Projects", and "Contact" are currently not working. They don’t navigate anywhere or are missing proper routing

buttonOneText: "View Demo",
buttonTwoText: "View Code",
tags: ["CSS", "HTML", "Responsive Design", ],
liveDemoLink: "https://hookitup.netlify.app",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployed Netlify site (https://hookitup.netlify.app/) is not working it only shows a blank white screen. Might be build errors or issues with rendering on deployment.

desktop: "1024px",
},
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your component structure is clean and easy to follow!!

</>
)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responsiveness looks great overall!
Suggestion:
Consider adding a hamburger menu or a collapsible navigation for smaller screens. A mobile-friendly menu would improve usability and make the design cleaner on smaller devices other wise super clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants