-
Notifications
You must be signed in to change notification settings - Fork 33
Portfolio - Tavan Thiry #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e will be added later
… of images in article cards
…ct section and project cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
✅
…ion and changed methods in skills section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, i have reviewed your portfolio now!
Couldn't find much to be picky on haha, really really great job I must say, clean and good looking portfolio, easy to follow and read, and a consistency in your code.
Well done! 🎉
<NavLink href="#aboutme">About Me</NavLink> | ||
</NavItem> | ||
<NavItem> | ||
<NavLink href="#projects">Projects</NavLink> | ||
</NavItem> | ||
<NavItem> | ||
<NavLink href="#contact">Contact</NavLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navbar links "About Me", "Projects", and "Contact" are currently not working. They don’t navigate anywhere or are missing proper routing
buttonOneText: "View Demo", | ||
buttonTwoText: "View Code", | ||
tags: ["CSS", "HTML", "Responsive Design", ], | ||
liveDemoLink: "https://hookitup.netlify.app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployed Netlify site (https://hookitup.netlify.app/) is not working it only shows a blank white screen. Might be build errors or issues with rendering on deployment.
desktop: "1024px", | ||
}, | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your component structure is clean and easy to follow!!
</> | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responsiveness looks great overall!
Suggestion:
Consider adding a hamburger menu or a collapsible navigation for smaller screens. A mobile-friendly menu would improve usability and make the design cleaner on smaller devices other wise super clean!
Deployed website: https://tavanthiry-portfolio.netlify.app
Figma Design: https://www.figma.com/files/team/1156152110766091222/project/369506812/Portfolio?fuid=1026812760676312115