Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding cover arts with
mp4art --add cover.jpg music.mp4
, some JPEG images get added asimplicit
type:in
type.cpp
:mp4v2/src/itmf/type.cpp
Lines 283 to 290 in 4fc9463
According to https://en.wikipedia.org/wiki/List_of_file_signatures,
"\xff\xd8\xff\xe0"
can only detect JPEG in JFIF formats.This commit added support for detecting raw JPEG and JPEG in Exif, so when adding arts, they won't get
BasicType
undetected.