Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: direct component access for rendering without container #14

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

saschb2b
Copy link
Member

@saschb2b saschb2b commented Oct 2, 2024

Goal was to expose the changelog list component to be used without any need for outer Container that injects the data from context. E.g. to render the changelog list when the data was fetched already in an another scope to just pass it on

<ComponentList changelogs={data && groupChangelogsByComponents(data)} />

Other remarks:

  • Defaulting changelogs props to empty array to prevent undefined checks around component
  • Extend existing ChangelogList to fit needs of MinimalChangelogList and deprecate MinimalChangelogList
  • The name "ComponentList" may not be a good fit. maybe we can iterate on that
  • changelog props only accepts type ChangelogWithComponents[] which implies the group util function. Ideally this would be solved via a prop internally to hide complexity and prevent type clutter

@saschb2b saschb2b requested a review from redbeard0091 October 2, 2024 14:05
@saschb2b saschb2b changed the title Feat/direct component access feat: direct component access for rendering without container Oct 2, 2024
@saschb2b saschb2b merged commit b309751 into master Oct 4, 2024
2 checks passed
@saschb2b saschb2b deleted the feat/direct-component-access branch October 4, 2024 09:42
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants