Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release date to changelog #12

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

saschb2b
Copy link
Member

image

@saschb2b saschb2b self-assigned this Sep 13, 2024
@saschb2b saschb2b requested review from leMaik and removed request for redbeard0091 and leMaik September 13, 2024 10:52
@saschb2b saschb2b added the enhancement New feature or request label Sep 16, 2024
lib/changelog.hook.ts Outdated Show resolved Hide resolved
Copy link
Member

@leMaik leMaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The sorting code could be simplified. useChangelogs doesn't handle stale requests (ie. component unmounted but request still running) but I'll add that in another PR.

Co-authored-by: Maik Marschner <[email protected]>
@saschb2b saschb2b requested a review from leMaik September 25, 2024 09:07
@saschb2b saschb2b merged commit b1f7db1 into master Sep 25, 2024
2 checks passed
@saschb2b saschb2b deleted the feat/changelog-release-date branch September 25, 2024 13:05
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants