Skip to content

Conversation

@theimpulson
Copy link
Member

@theimpulson theimpulson commented Dec 13, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes "Enqueue next" after 150649a

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@theimpulson theimpulson requested a review from TobiGr December 13, 2025 09:06
@theimpulson theimpulson added the bug Issue is related to a bug label Dec 13, 2025
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Dec 13, 2025
@theimpulson
Copy link
Member Author

I am unsure if this is the expected behavior of enqueue next but this adds the item to the existing queue but as the 3rd index if we are currently playing at 1st. I would expect enqueue next to add the items at 2nd index. is 3rd the expected behavior?

@TobiGr TobiGr added the queue Issue is related to queueing label Dec 13, 2025
@theimpulson
Copy link
Member Author

I am unsure if this is the expected behavior of enqueue next but this adds the item to the existing queue but as the 3rd index if we are currently playing at 1st. I would expect enqueue next to add the items at 2nd index. is 3rd the expected behavior?

Nevermind, seems the UI is not properly updated to reflect the change. Seems like a different bug. Workaround is enqueuing an item which forces to update the UI properly.

@TobiGr
Copy link
Contributor

TobiGr commented Dec 13, 2025

I also noticed that, the interesting thing is that it only happens with the background player for me:

Video Player Background Player
Video Player.webm Background Player.webm

Notice that the items are swapped when opening the fragment. Maybe something is not cleared correctly.

Should we open a new issue for that?

Edit:

In PlayQueueAdapter, onNext() is called again when opening the View.

@TobiGr TobiGr added this to v0.28.x Dec 13, 2025
@github-project-automation github-project-automation bot moved this to Todo in v0.28.x Dec 13, 2025
@TobiGr TobiGr moved this from Todo to In Progress in v0.28.x Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug queue Issue is related to queueing size/small PRs with less than 50 changed lines

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[Regression] Enqueue next doesn't work

3 participants