Skip to content

Conversation

whistlingwoods
Copy link
Contributor

@whistlingwoods whistlingwoods commented Aug 17, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR changes the app behavior where it considers ERROR_PROGRESS_LOST as invalid storage, however where it is possible to recover the pending download missions, it tries for that.

Fixes the following issue(s)

Fix app can't resume paused downloads in certain following situations:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@ShareASmile
Copy link
Collaborator

Steps to follow for rigorously testing the fix under different conditions:

  1. Try to download a large file under unstable network conditions e.g. pause it while you are leaving wifi area to save cellular data and try to resume the download when wifi becomes available again after some time.

  2. While downloading keep app in background, pause it and open other heavy ram usage apps to boot it out of memory then reopen app to check if video is still there in downloads list and whether it resumes the download when started again manually from downloads list.

@ABJ4403
Copy link

ABJ4403 commented Aug 18, 2025

2. While downloading keep app in background, pause it and open other heavy ram usage apps to boot it out of memory then reopen app to check if video is still there in downloads list and whether it resumes the download when started again manually from downloads list.

Does am kill-all count? Bcz i'd rather do that, tho i have 2nd device that has 2GB RAM and filled up so quick when i load up a game, so i could try thatvas well

… gets killed

Author: InfinityLoop1308
Adapted for NewPipe from a fork's this commit InfinityLoop1308/PipePipeClient@1cf059c
@whistlingwoods whistlingwoods force-pushed the fix-downloads-lost-progress branch from 23793e3 to 9282cce Compare August 21, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader size/medium PRs with less than 250 changed lines
Projects
Status: In Progress
3 participants