Migrate watch history to Jetpack Compose #11947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShareASmile
added
history
# Conflicts: # app/src/main/java/org/schabi/newpipe/local/history/StatisticsPlaylistFragment.java
# Conflicts: # app/src/main/java/org/schabi/newpipe/ui/components/items/stream/StreamMenu.kt
|
There should be a confirmation screen after "clear history" button clicked I guess |
Isira-Seneviratne
force-pushed
the
History-Compose
branch
2 times, most recently
from
135d560 to
e5882af
Compare
Would you please restore earlier default behavior of "sort by" to "date", it defaults to "views" in this PR. Also noticed a minor bug: last selected option isn't saved, it switches to sort by "views" even after manually changing it to sort by "date" after reopening the app. |
Okay.
That's because the selected option is not being persisted (the existing app doesn't do it, either). |
# Conflicts: # app/src/main/res/values-be/strings.xml
Isira-Seneviratne
force-pushed
the
History-Compose
branch
from
de7b8d3 to
451c89b
Compare
|
# Conflicts: # gradle/libs.versions.toml
# Conflicts: # app/src/main/java/org/schabi/newpipe/ui/components/video/RelatedItems.kt # app/src/main/java/org/schabi/newpipe/ui/emptystate/EmptyStateUtil.kt
|
|
Produces Error on data export, I can export with playlist fragment to Jetpack compose PR fine (as I am currently testing the two) It looks specific to this PR or Exception
Crash log
|
Yes, I had to update the Room version in this PR in order to use PagingSource. |
|
@ShareASmile It should be working now. |
|
Just did a quick test and now it works flawlessly. Thank you for all your efforts :). |
# Conflicts: # app/src/main/java/org/schabi/newpipe/ui/components/items/stream/StreamMenu.kt
# Conflicts: # app/src/main/java/org/schabi/newpipe/settings/BackupRestoreSettingsFragment.java # gradle/libs.versions.toml
Isira-Seneviratne
force-pushed
the
History-Compose
branch
from
063b88a to
48d0ebf
Compare
Isira-Seneviratne
added
the
ready for review
10 tasks
# Conflicts: # app/src/main/java/org/schabi/newpipe/settings/BackupRestoreSettingsFragment.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screen_recording_20250311_110112.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence