[FIX/#178] PlaylistView 오류 해결 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Junu-Pak <[email protected]> Co-authored-by: WooFeather <[email protected]>
6 tasks
Co-authored-by: Junu-Pak <[email protected]> Co-authored-by: WooFeather <[email protected]>
WooFeather
commented
Nov 3, 2024
Comment on lines
+191
to
+202
| /// 플레이리스트를 업데이트합니다. 이미지URL을 받습니다. | ||
| func updatePlaylist(playlistId: Int, title: String, imageUrl: String?) async -> Result<Void, any Error> { | ||
|
|
||
| let request = UpdatePlaylistRequest(title: title, playlistImageUrl: imageUrl ?? "") | ||
| let response = await playlistRepository.updatePlaylist(request: request, playlistId: Int64(playlistId)) | ||
| switch response { | ||
| case .success: | ||
| return .success(()) | ||
| case .failure(let error): | ||
| return .failure(error) | ||
| } | ||
| } |
There was a problem hiding this comment.
원래의 UIImage?타입을 받는 함수에서는 기본 이미지(url)을 저장해놓을수 없어서
imageUrl 즉, String?타입을 받는 함수를 별도로 만들었습니다.
WooFeather
commented
Nov 3, 2024
Comment on lines
+63
to
+71
| if let selectedImg = selectedImage { | ||
| await playlistUseCase.updatePlaylist( | ||
| playlistId: Int(selectedPlaylist.id), | ||
| title: selectedPlaylist.title, | ||
| image: selectedImage | ||
| ) | ||
| } else { | ||
| await playlistUseCase.updatePlaylist(playlistId: Int(selectedPlaylist.id), title: selectedPlaylist.title, imageUrl: selectedPlaylist.imageUrl) | ||
| } |
There was a problem hiding this comment.
플레이리스트 편집을 할 때 이미지를 변경한 경우 selectedImage를 전달해주고,
이미 설정해놓은 이미지가 있는 상태에서 변경없이 완료를 누른 경우 원래 설정되어있던 imageUrl을 전달합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #178
⛳️ Work Description
📸 Screenshot
📢 To Reviewers
✅ Checklist