Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] 임시 목업 데이터 변경 #72

Merged
merged 2 commits into from
Oct 6, 2024
Merged

[TEST] 임시 목업 데이터 변경 #72

merged 2 commits into from
Oct 6, 2024

Conversation

dgh06175
Copy link
Contributor

@dgh06175 dgh06175 commented Oct 6, 2024

PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

반영 브랜치

ex) test/#71/testDataChange -> develop

변경 사항

임시 데이터 생성 로직 약간 수정, ISRC 실제 데이터로 변경

테스트 결과

통과

@dgh06175 dgh06175 added the enhancement New feature or request label Oct 6, 2024
@dgh06175 dgh06175 self-assigned this Oct 6, 2024
@dgh06175 dgh06175 linked an issue Oct 6, 2024 that may be closed by this pull request
[TEST] 테스트 데이터의 ISRC 실제 데이터로 변경 #71
Closed
2 tasks
crownjoe
crownjoe approved these changes Oct 6, 2024
View reviewed changes
Copy link

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티비~~

WooFeather
WooFeather approved these changes Oct 6, 2024
View reviewed changes
Copy link

@WooFeather WooFeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 정말 좋은 코드네요 LGTM👍

Junu-Park
Junu-Park approved these changes Oct 6, 2024
View reviewed changes
Copy link

@Junu-Park Junu-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬~~~에이스의 코드 LGTM👍

@dgh06175 dgh06175 merged commit 1c697f1 into develop Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junu-Park Junu-Park Junu-Park approved these changes

@crownjoe crownjoe crownjoe approved these changes

@WooFeather WooFeather WooFeather approved these changes

@thinkySide thinkySide Awaiting requested review from thinkySide

Assignees

@dgh06175 dgh06175

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] 테스트 데이터의 ISRC 실제 데이터로 변경
4 participants
@dgh06175 @Junu-Park @crownjoe @WooFeather