Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react-router): reproducer starter for #2255 #2262

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

SeanCassiere
Copy link
Member

Important

These reproductions need to be corrected to match the expected route tree and the content to be displayed on the screen.

Starting for the reproductions for #2255

Copy link

nx-cloud bot commented Sep 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f11d3de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

More templates

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2262

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2262

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2262

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2262

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2262

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2262

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2262

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2262

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2262

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2262

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2262

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2262

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2262

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2262

commit: f11d3de

@SeanCassiere
Copy link
Member Author

Currently, we've identified 3 scenarios that need resolution.

  1. /about route with an async loader where this is thrown notFound()
<root.NotFoundComponent />
  1. /about route with a non-async loader where this is thrown notFound()
<root.Component>
  <@tanstack/react-router->DefaultGlobalNotFound />
</root.Component>
  1. /route-that-does-not-exist
<root.Component>
  <root.NotFoundComponent />
</root.Component>

2 definitely shouldn't be happening since it should be traversing up the route-tree to select the notFoundComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant