Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): correctly pass activeProps and inactiveProps to custom link created through createLink #2092

Closed
wants to merge 1 commit into from

Conversation

schiller-manuel
Copy link
Contributor

fixes #2079

…o custom link created through `createLink`

fixes #2079
Copy link

nx-cloud bot commented Aug 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 250da61. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 6, 2024

commit: 250da61

pnpm add https://pkg.pr.new/@tanstack/history@2092
pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2092
pnpm add https://pkg.pr.new/@tanstack/react-router@2092
pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2092
pnpm add https://pkg.pr.new/@tanstack/router-cli@2092
pnpm add https://pkg.pr.new/@tanstack/router-devtools@2092
pnpm add https://pkg.pr.new/@tanstack/router-generator@2092
pnpm add https://pkg.pr.new/@tanstack/router-plugin@2092
pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2092
pnpm add https://pkg.pr.new/@tanstack/start@2092
pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2092

Open in Stackblitz

More templates

@@ -557,23 +557,24 @@ type LinkCurrentTargetElement = {
const preloadWarning = 'Error preloading route! ☝️'

export function useLinkProps<
TComp extends React.ElementType = 'a',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be HTMLAnchorElement by default? (see related Discord thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using createLink(), activeProps type should allow component props
2 participants