Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using createLink(), activeProps type should allow component props #2079

Closed
olivierpascal opened this issue Aug 3, 2024 · 0 comments · Fixed by #2347
Closed

When using createLink(), activeProps type should allow component props #2079

olivierpascal opened this issue Aug 3, 2024 · 0 comments · Fixed by #2347
Labels
types Changes to the typescript types

Comments

@olivierpascal
Copy link

olivierpascal commented Aug 3, 2024 •
edited
Loading

Describe the bug

image

TS error: Object literal may only specify known properties, and 'selected' does not exist in type 'AnchorHTMLAttributes<HTMLAnchorElement> | (() => AnchorHTMLAttributes<HTMLAnchorElement>)'.

Beside, no className should be provided to component to make this function completely agnostic.

Your Example Website or App

https://stackblitz.com/edit/github-ayifmj?file=src%2Fmain.tsx,src%2Froutes%2Findex.tsx

Steps to Reproduce the Bug or Issue

Click on the stackblitz link and notice the TS error.

Expected behavior

No TS error.

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
types Changes to the typescript types
Projects
None yet
Milestone
No milestone
2 participants
@olivierpascal @SeanCassiere