Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-query): eslint-plugin-query now working with vanilla js #8322

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix(react-query): eslint-plugin-query now working with vanilla js #8322

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e370c95
fix: eslint-plugin-query not working with vanilla js
ShyneADL Nov 21, 2024
0e6ba7a
Merge branch 'main' into eslint-plugin-issue
TkDodo Nov 22, 2024
4341ca7
Update packages/eslint-plugin-query/src/utils/detect-react-query-impo…
TkDodo Nov 22, 2024
0a4e9fd
Merge branch 'main' into eslint-plugin-issue
TkDodo Nov 22, 2024
f59de1b
Disabled linter for conditional statement
ShyneADL Nov 23, 2024
b23e44b
Merge branch 'main' into eslint-plugin-issue
lachlancollins Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/eslint-plugin-query/src/utils/detect-react-query-imports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ export function detectTanstackQueryImports(create: EnhancedCreate): Create {
ImportDeclaration(node) {
if (
node.specifiers.length > 0 &&
node.importKind === 'value' &&
// Change condition to check for undefined or 'value'
(node.importKind === 'value' || node.importKind === undefined) &&
TkDodo marked this conversation as resolved.
Show resolved Hide resolved
node.source.value.startsWith('@tanstack/') &&
node.source.value.endsWith('-query')
) {
Expand Down
Loading