Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove _TData abstraction #465

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: remove _TData abstraction #465

merged 2 commits into from
Sep 14, 2023

Conversation

tannerlinsley
Copy link
Collaborator

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
packages/form-core/src/utils.ts ø
packages/react-form/src/createFormFactory.ts ø
packages/form-core/src/FieldApi.ts 100.00%
packages/form-core/src/FormApi.ts 100.00%
packages/react-form/src/useField.tsx 100.00%
packages/react-form/src/useForm.tsx 100.00%

📢 Thoughts on this report? Let us know!.

@tannerlinsley
Copy link
Collaborator Author

I'm a big fan of this change for a few reasons:

  • Less code
  • Uniform generic slot names and order across the library
  • Still approachable for constraints e.g.

@tannerlinsley tannerlinsley merged commit 638a391 into main Sep 14, 2023
5 checks passed
@tannerlinsley tannerlinsley deleted the feat-no-pre-t-data branch September 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants