-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): Component default scoped slot value types #451
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Now's the best time to do breaking changes, let's do it! 😄 Thanks for this change. BTW, have you seen the typings for form/packages/vue-form/src/useField.tsx Lines 115 to 134 in f6bb80e
I don't think this is right, but no matter what I tried to update, I couldn't get the TSX in our tests working properly and had to resort to manually typing
This would be amazing to get fixed, any chance you have an idea of how to do so? |
Added an update for the
@crutchcorn Unfortunately no, I think typed scoped slots only supports SFC as of now. Even tried to do a quick component with a default slot to check its type: That's plain TS and it can't still pick up the slot value types. |
That's what I ran into as well.. Do we wanna just remove the |
@crutchcorn Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you for your help and patience!
Hi! This PR adds typings to the
Subscribe
andField
component default slot values.Some reference: vuejs/core#7982
Tests passed ✅