-
-
Notifications
You must be signed in to change notification settings - Fork 14
Some optimizations ( type safe, avoid unnecessary memory manage, etc...). #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Daylily-Zeleen
wants to merge
42
commits into
TaloDev:develop
from
Daylily-Zeleen:daylily-zeleen/optimize
Closed
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
be14434
Merge pull request #1 from TaloDev/develop
tudddorrr cb6c56e
Merge pull request #2 from TaloDev/develop
tudddorrr 778b832
Merge pull request #3 from TaloDev/develop
tudddorrr 8e64536
Merge pull request #4 from TaloDev/develop
tudddorrr ee4515a
Merge pull request #7 from TaloDev/develop
tudddorrr 203e92b
Merge pull request #9 from TaloDev/develop
tudddorrr c35f092
Merge pull request #11 from TaloDev/develop
tudddorrr ea2ddf5
Merge pull request #13 from TaloDev/develop
tudddorrr b8a016b
Merge pull request #15 from TaloDev/develop
tudddorrr 25395aa
Merge pull request #18 from TaloDev/develop
tudddorrr 5e407ac
Merge pull request #20 from TaloDev/develop
tudddorrr 58bde26
Merge pull request #21 from TaloDev/develop
tudddorrr 923b972
Merge pull request #23 from TaloDev/develop
tudddorrr 643e168
Merge pull request #27 from TaloDev/develop
tudddorrr 5de74c4
Merge branch 'develop'
tudddorrr 879cc4d
Merge pull request #30 from TaloDev/develop
tudddorrr 1a61ae6
Merge pull request #32 from TaloDev/develop
tudddorrr effad38
Merge pull request #35 from TaloDev/develop
tudddorrr b42ba80
Merge pull request #38 from TaloDev/develop
tudddorrr 8faf833
Merge pull request #44 from TaloDev/develop
tudddorrr 3de6d86
Merge pull request #46 from TaloDev/develop
tudddorrr 1c5edff
Merge branch 'develop'
tudddorrr 64ee25e
Merge pull request #51 from TaloDev/develop
tudddorrr 9d92c68
Merge pull request #54 from TaloDev/develop
tudddorrr 41aa029
Merge pull request #56 from TaloDev/develop
tudddorrr bd12ee0
Merge pull request #61 from TaloDev/develop
tudddorrr aae5f0c
Merge pull request #64 from TaloDev/develop
tudddorrr 494ca10
Merge pull request #66 from TaloDev/develop
tudddorrr 9cdff0c
Merge pull request #68 from TaloDev/develop
tudddorrr 43bbe6d
Use `RefCounted` instead of `Node` to avoid unnecessary memory manage.
Daylily-Zeleen dbff565
Optimize leaderboard api.
Daylily-Zeleen db8745e
Optimize channels api.
Daylily-Zeleen e102a74
Let GameConfigAPI.get_live_config() return the TaloLiveConfig( useful…
Daylily-Zeleen 62fa464
Let PlayerAuthAPI.login() return `LoginResult` instead of an Array.
Daylily-Zeleen 67f3d67
Let some apis in PlayerAPI return `TaloPlayer` directly( for async pr…
Daylily-Zeleen 06c70bb
1. Some tiny fix.
Daylily-Zeleen fca7f04
Disallow SavesManager to emit SavesAPI's signals.
Daylily-Zeleen 49fb607
Try to create default settings file when plugin enabling instead of a…
Daylily-Zeleen 6296cce
Rename "is_last_page" to "last_page".
Daylily-Zeleen 1af9d39
Update samples to adapt to changes of SDK.
Daylily-Zeleen 6d7e781
Rename "TimeUtils" to "TaloTimeUtils".
Daylily-Zeleen d831939
Add missing channel events/signals.
Daylily-Zeleen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will use this file as a base for most of my comments:
class_name xAPI extends TaloAPIformat - unless there's any reason not to. I like the declarative nature of showing exactly what the class name is.p_prefixes on variable names. I understand the idea behind it but I don't think the values are being shadowed in the same way they would be in other languages.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class_nameis global scope, it will contaminate user's namespace. Anyclass_namein plugin should be thought twice.If you definitely want to keep them has an explicit class name, we can consider to user an independence script with a
class_nameand declare other scripts as a constant value like in "talo_manager.gd" in this pre.For example:
If we consider to change the argument "name" and fix relate logic partially, it will be like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully see your point and agree in principle but I think the main problem with polluting namespaces is naming collisions. I'm hopeful that one day gdscript will add namespaces but until then I think 99.9% of Godot projects won't have any naming collisions with any of the Talo APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t assume the user's naming preferences. For example,
TimeUtils, it is entirely possible for the user to create type with the same name.At least we need to add the prefix "Talo" to all Talo types like the C language library.
We can consider it from another perspective, reduce expose unnecessary types to users can reduce the number of related types in the completion list when users type "Talo" in code editor, so user can ignore them. This reduces unnecessary complexity and keep the simplicity of the API.
Especially for some types in the "utilis" folder, they are completely inaccessible to users but have a global class name, this is completely inappropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think adding Talo as a prefix to the APIs is a good middle ground, especially because that won't lead to a breaking change