Skip to content

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Dec 22, 2024
@tudddorrr tudddorrr changed the title Add socket events clickhouse table for observability Add socket events ClickHouse table for observability Dec 22, 2024
@codecov
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 98.61751% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.82%. Comparing base (0ccef43) to head (f2f3850).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/socket/router/socketRouter.ts 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #377    +/-   ##
=========================================
  Coverage    99.82%   99.82%            
=========================================
  Files          179      180     +1     
  Lines        13060    13177   +117     
  Branches       830      843    +13     
=========================================
+ Hits         13037    13154   +117     
  Misses          21       21            
  Partials         2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tudddorrr tudddorrr force-pushed the socket-observability branch from c5d8728 to ae27f2e Compare December 22, 2024 22:32
@tudddorrr tudddorrr force-pushed the socket-observability branch from ae27f2e to 48a7472 Compare December 22, 2024 22:47
@tudddorrr tudddorrr merged commit 79efca0 into develop Dec 23, 2024
4 of 5 checks passed
@tudddorrr tudddorrr deleted the socket-observability branch December 23, 2024 21:43
@sentry
Copy link

sentry bot commented Dec 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'game') new SocketConnection(socketConnection.ts) View Issue
  • ‼️ TypeError: Invalid URL <anonymous>(index.ts) View Issue
  • ‼️ Error: Invalid message data for request sendError(socketError.ts) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants