Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vscode): add inline edit on context menu #3675

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat(vscode): add inline edit on context menu #3675

merged 1 commit into from
Jan 13, 2025

Conversation

zhanba
Copy link
Contributor

@zhanba zhanba commented Jan 11, 2025 •
edited
Loading

Feature

  • add inline edit on context menu
  • fix VSCode extension build problem on windows
  • update VSCode extension contributing doc

demo :

https://jam.dev/c/cb8d3d3f-5d8e-4edd-bd7d-91d5a697bc87

screenshot:
image

issue #3423

@zhanba zhanba force-pushed the feat-inline-edit-context branch 3 times, most recently from 9595a7e to b3d54b2 Compare January 13, 2025 01:59
@icycodes
Copy link
Member

icycodes commented Jan 13, 2025 •
edited
Loading

@zhanba Thank you for this PR.
Could you please add a separator line between the Start Inline Editing command and the two above?

@zhanba zhanba force-pushed the feat-inline-edit-context branch from b3d54b2 to 4308aa2 Compare January 13, 2025 02:45
@zhanba
Copy link
Contributor Author

zhanba commented Jan 13, 2025 •
edited
Loading

@zhanba Thank you for this PR. Could you please add a separator line between the Start Inline Editing command and the two above?

Ok. Should we put Start Inline Editing in the first of the three menus?

@zhanba zhanba force-pushed the feat-inline-edit-context branch from db8068a to 7911efa Compare January 13, 2025 03:22
@icycodes
Copy link
Member

LGTM, Thanks again.

@icycodes icycodes merged commit f67a3fe into TabbyML:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhanba @icycodes