Merge pull request #4 from TSurkis/recyclerview_no_adapter_crash_fix

Crash fix
TSurkis · Mar 17, 2019 · 6cea69c · 6cea69c
2 parents 456739d + b509869
commit 6cea69c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -27,5 +27,5 @@ dependencies {
     implementation 'com.android.support:appcompat-v7:28.0.0'
     implementation "com.android.support:recyclerview-v7:28.0.0"
 
-    implementation 'com.github.tsurkis:timdicator:1.2.2'
+    implementation 'com.github.tsurkis:timdicator:1.2.3'
 }
diff --git a/timdicator/build.gradle b/timdicator/build.gradle
@@ -9,7 +9,7 @@ android {
         minSdkVersion 14
         targetSdkVersion 28
         versionCode 7
-        versionName "1.2.2"
+        versionName "1.2.3"
     }
 
     buildTypes {

diff --git a/timdicator/src/main/java/com/tsurkis/timdicator/TimdicatorBinder.java b/timdicator/src/main/java/com/tsurkis/timdicator/TimdicatorBinder.java
@@ -39,9 +39,8 @@ public static TimdicatorViewPagerBinder attachViewPagerDynamically(@NonNull Timd
         return timdicatorViewPagerBinder;
     }
 
-    public static TimdicatorRecyclerViewBinder attachRecyclerView(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal) {
+    public static void attachRecyclerView(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal) {
         TimdicatorRecyclerViewBinder timdicatorRecyclerViewBinder = new TimdicatorRecyclerViewBinder();
         timdicatorRecyclerViewBinder.attach(timdicator, recyclerView, snapHelper, isHorizontal);
-        return timdicatorRecyclerViewBinder;
     }
 }
diff --git a/timdicator/src/main/java/com/tsurkis/timdicator/TimdicatorRecyclerViewBinder.java b/timdicator/src/main/java/com/tsurkis/timdicator/TimdicatorRecyclerViewBinder.java
@@ -83,17 +83,18 @@ private void updateTimdicator(int newNumberOfCircles) {
     }
   };
 
-  public void attach(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal) {
+  void attach(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal) {
     attach(timdicator, recyclerView, snapHelper, isHorizontal, recyclerView.getAdapter() != null ? recyclerView.getAdapter().getItemCount() : 0);
   }
 
-  public void attach(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal, int initialIndex) {
+  void attach(@NonNull Timdicator timdicator, @NonNull RecyclerView recyclerView, @NonNull SnapHelper snapHelper, boolean isHorizontal, int initialIndex) {
     this.timdicator = timdicator;
     this.recyclerView = recyclerView;
     this.snapHelper = snapHelper;
     this.isHorizontal = isHorizontal;
     recyclerView.addOnScrollListener(scrollListener);
     if (recyclerView.getAdapter() != null) {
+      recyclerView.getAdapter().registerAdapterDataObserver(recyclerViewChangesObserver);
       timdicator.setNumberOfCircles(recyclerView.getAdapter().getItemCount());
       timdicator.requestLayout();
     }
@@ -106,7 +107,6 @@ public void attach(@NonNull Timdicator timdicator, @NonNull RecyclerView recycle
     if (isReversed) {
       timdicator.setIndex(initialIndex);
     }
-    recyclerView.getAdapter().registerAdapterDataObserver(recyclerViewChangesObserver);
   }
 
   @Override