Skip to content

Conversation

@kunlin596
Copy link
Collaborator

@kunlin596 kunlin596 commented May 16, 2025

Changes:

  1. Narrow down the version of grpcio and grpcio-tools to correctly fix protobuf 4.
  2. Fix the package version fetching.
  3. Remove unnecessary build_proto.py.

@kunlin596 kunlin596 force-pushed the kun/fix/remove-protobuf-upper-bound branch from cf525d0 to d0dbf63 Compare May 16, 2025 03:50
@kunlin596 kunlin596 changed the title fix: remove protobuf version upper bound fix: pin the versions of grpcio and grpcio-tools May 21, 2025
@kunlin596 kunlin596 force-pushed the kun/fix/remove-protobuf-upper-bound branch from f7c83c5 to 90c7e0e Compare May 21, 2025 03:24
@kunlin596 kunlin596 requested a review from chrisochoatri May 21, 2025 03:24
@kunlin596 kunlin596 force-pushed the kun/fix/remove-protobuf-upper-bound branch from d6cd17d to 1d95d4f Compare May 21, 2025 04:31
Changes:

    1. Narrow down the version of grpcio and grpcio-tools to correctly fix protobuf 4.
    2. Fix the package version fetching.
    3. Remove unnecessary build_proto.py.
@kunlin596 kunlin596 force-pushed the kun/fix/remove-protobuf-upper-bound branch from 1d95d4f to 282c4c5 Compare May 21, 2025 04:55
Copy link
Collaborator

@chrisochoatri chrisochoatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunlin596 kunlin596 merged commit ae60c48 into master May 22, 2025
3 checks passed
@kunlin596 kunlin596 deleted the kun/fix/remove-protobuf-upper-bound branch May 22, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants