Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get rid of red error marker in get_components_from_service #620

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Aug 8, 2024

Which issue(s) this PR fixes

Fixes None

Additional comments

  • Get rid of red error marker in get_components_from_service in Collections class.
  • Get rid of red error marking in Dag class.

Agreements

@SteBaum SteBaum self-assigned this Aug 8, 2024
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the Dag fix.

For the Collections.get_components_from_service, we may just want to remove the Operation.is_service_operation method entirely and replace it with what you suggested (checking the Operation.component_name value).

@SteBaum SteBaum force-pushed the stephan/fix/get_components_from_service branch from a1c19d8 to 4f2ad36 Compare October 21, 2024 08:24
@SteBaum
Copy link
Contributor Author

SteBaum commented Oct 21, 2024

Agree with the Dag fix.

For the Collections.get_components_from_service, we may just want to remove the Operation.is_service_operation method entirely and replace it with what you suggested (checking the Operation.component_name value).

Yes both are mutually exclusive so we do not need both. I removed Operation.is_service_operation with last force push.

tdp/core/dag.py Outdated Show resolved Hide resolved
@PaulFarault
Copy link
Contributor

PaulFarault commented Oct 22, 2024

I suggest we close this PR that only fixes the symptoms and not the main issues.

I opened #625 for the is_service_operation, we'll need to discuss if we should make the collection_name mandatory for the Operation.

@SteBaum SteBaum reopened this Oct 22, 2024
@SteBaum SteBaum force-pushed the stephan/fix/get_components_from_service branch from 4f2ad36 to 9016476 Compare October 22, 2024 14:54
@SteBaum SteBaum merged commit 220ae91 into master Oct 22, 2024
5 checks passed
@SteBaum SteBaum deleted the stephan/fix/get_components_from_service branch October 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants