Refactor/collections init operations #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteBaum
approved these changes
Feb 9, 2024
Inventory reader should be passed directly so that it is used by the Collection __init__
PaulFarault
force-pushed
the
refactor/collections-init-operations
branch
from
3161414 to
ede2005
Compare
rpignolet
reviewed
Feb 15, 2024
PaulFarault
force-pushed
the
refactor/collections-init-operations
branch
from
1dcc3a1 to
cad3850
Compare
|
@rpignolet I rolled back the |
PaulFarault
force-pushed
the
refactor/collections-init-operations
branch
from
cad3850 to
7914ccf
Compare
rpignolet
approved these changes
Feb 20, 2024
SteBaum
reviewed
Feb 20, 2024
SteBaum
approved these changes
Feb 20, 2024
PaulFarault
force-pushed
the
refactor/collections-init-operations
branch
from
1a20184 to
d52fe14
Compare
|
Force pushed after squashing and rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
Additional comments
This PR addresses the issue with assigning
collection_namevalues. Previously, the assignedcollection_namewas that of the first collection in which the operation was specified in the DAG. Now, thecollection_namefor a playbook is the one in which the playbook is defined.Another key benefit of this PR is the decoupling of the
Operationcreation logic. Playbook operations are now exclusively forged withinCollection, andCollectionsis limited to forging Noop operations only.I've intentionally broken down the PR into numerous commits to ease the review process. The most significant logic change is found in the "refactor: create playbook operations in Collection" commit.
Agreements