Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added a raise Exception message No planned deployment if none #542

Closed
wants to merge 1 commit into from
Closed

feat: added a raise Exception message No planned deployment if none #542

wants to merge 1 commit into from

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Jan 23, 2024 •
edited
Loading

Which issue(s) this PR fixes

Fixes None

Additional comments

Added a raise Exception message No planned deployment if there is none.

Agreements

@SteBaum SteBaum self-assigned this Jan 23, 2024
PaulFarault
PaulFarault reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The try/except doesn't provide any value as it is only switching a NoResultFound exception to a very generic Exception type.

@SteBaum SteBaum closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulFarault PaulFarault PaulFarault left review comments

Assignees

@SteBaum SteBaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteBaum @PaulFarault