Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceVariables: deduce service name from repository path #528

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

PaulFarault
Copy link
Contributor

@PaulFarault PaulFarault commented Nov 24, 2023

Which issue(s) this PR fixes

Fixes None

No need to pass the name as an argument as it is induced by the variable directory path.

Agreements

@PaulFarault PaulFarault self-assigned this Nov 24, 2023
@PaulFarault PaulFarault force-pushed the service-variables-name branch from 0b56ed1 to 17ad401 Compare November 24, 2023 14:43
@SteBaum SteBaum self-requested a review November 24, 2023 16:22
Copy link
Contributor

@mdrutel mdrutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested OK

@PaulFarault PaulFarault merged commit dd94078 into master Nov 29, 2023
5 checks passed
@PaulFarault PaulFarault deleted the service-variables-name branch November 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants