Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceVariables: merge variables importation logic #524

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

PaulFarault
Copy link
Contributor

@PaulFarault PaulFarault commented Nov 24, 2023

Which issue(s) this PR fixes

Fixes None

Simplifies the import of variables which was split accros multiple methods that were not reused. Current version feels a bit over-engineered, probably because at first we wanted to expose some public API with tdp-lib.

Agreements

@PaulFarault PaulFarault added the enhancement New feature or request label Nov 24, 2023
@PaulFarault PaulFarault self-assigned this Nov 24, 2023
@PaulFarault PaulFarault force-pushed the refactor-variables branch 3 times, most recently from 3d17a17 to 2684669 Compare November 24, 2023 14:12
@PaulFarault PaulFarault changed the title Simplify variables importation to tdp_vars ServiceVariables: merge variables importation logic Nov 24, 2023
@PaulFarault
Copy link
Contributor Author

We must be able to edit several var files at the same time (as open_var_files did).

@PaulFarault PaulFarault force-pushed the refactor-variables branch 2 times, most recently from ac30d42 to 97dfd71 Compare November 29, 2023 13:52
@PaulFarault
Copy link
Contributor Author

Done. I switched back to an open_files method that yield a dict of opened files.

@PaulFarault PaulFarault merged commit 20d0ea3 into master Dec 7, 2023
5 checks passed
@PaulFarault PaulFarault deleted the refactor-variables branch December 7, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants