Check if file is writable before flushing #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergkudinov
reviewed
Nov 23, 2023
|
I added a unit test for that |
sergkudinov
approved these changes
Nov 23, 2023
SteBaum
approved these changes
Nov 28, 2023
rpignolet
reviewed
Nov 28, 2023
PaulFarault
force-pushed
the
fix-variables-file
branch
from
c9c5330 to
b05a1b2
Compare
rpignolet
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
Additional comments
IMO it makes more sense to check if the file is writable before flushing on disk.
Flushing on disk on a non writable file should raise an error.
Agreements