Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Variables.merge param type #521

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix Variables.merge param type #521

merged 1 commit into from
Nov 22, 2023

Conversation

PaulFarault
Copy link
Contributor

Which issue(s) this PR fixes

Fixes None

Fix Variables.merge param type from dict to MutableMapping to be coherent with Ansible merge_hash method.

Agreements

@PaulFarault PaulFarault self-assigned this Nov 22, 2023
@mdrutel mdrutel self-requested a review November 22, 2023 14:09
@SteBaum SteBaum self-requested a review November 22, 2023 14:10
mdrutel
mdrutel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mdrutel mdrutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested variable edition : OK

@PaulFarault PaulFarault merged commit a8b7fdd into master Nov 22, 2023
5 checks passed
@PaulFarault PaulFarault deleted the fix-mutable-mapping-type branch November 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrutel mdrutel mdrutel approved these changes

@SteBaum SteBaum Awaiting requested review from SteBaum

Assignees

@PaulFarault PaulFarault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulFarault @mdrutel