Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#443: Update README.md #512

Merged
merged 4 commits into from
Nov 21, 2023
Merged

#443: Update README.md #512

merged 4 commits into from
Nov 21, 2023

Conversation

PaulFarault
Copy link
Contributor

Which issue(s) this PR fixes

Fixes #443

Additional comments

Agreements

@PaulFarault PaulFarault self-assigned this Nov 16, 2023
@PaulFarault PaulFarault linked an issue Nov 16, 2023 that may be closed by this pull request
@PaulFarault PaulFarault changed the title #443: Update readme requirements #443: Update README.md Nov 16, 2023
@sergkudinov
Copy link
Contributor

I launched a discussion about aligning the names of all the TDP repos - https://github.com/orgs/TOSIT-IO/discussions/92

Also, I'm not sure, if interchanging with the names in inline-code syntax is justified (like "TDP Lib" and "tdp-lib").

@PaulFarault
Copy link
Contributor Author

tdp-lib is the name of the Python lib. The whole usable project is TDP Manager. IMO "TDP Lib" is not an official name.

@sergkudinov
Copy link
Contributor

ok, in that sense is ok, and for interchangeability.

but if you write "TDP Lib", it deserves an uppercase

Remove poetry and docs dependencies from the main requirements.
Rephrase some part of the README to make it easier to follow.
@PaulFarault PaulFarault force-pushed the 443-update-readme-requirements branch from 87f2801 to df2bbbf Compare November 20, 2023 09:55
@PaulFarault
Copy link
Contributor Author

Just removed the last occurrence of "TDP lib".

README.md Outdated Show resolved Hide resolved
Co-authored-by: Romain Pignolet <[email protected]>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Romain Pignolet <[email protected]>
@PaulFarault PaulFarault merged commit 5e43841 into master Nov 21, 2023
5 checks passed
@PaulFarault PaulFarault deleted the 443-update-readme-requirements branch November 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README requirements
3 participants