feat(content): issue 346 transformed playbook.py into script instead …

…of tdp-lib command

tdp/cli/commands/playbooks.py → scripts/playbooks.py

@@ -1,37 +1,26 @@
 # Copyright 2022 TOSIT.IO
 # SPDX-License-Identifier: Apache-2.0
 
+import argparse
+import os
 from pathlib import Path
+from typing import Optional
 
-import click
 import networkx as nx
 
-from tdp.cli.utils import collections
+from tdp.core.collection import Collection
+from tdp.core.collections import Collections
 from tdp.core.dag import DEFAULT_SERVICE_PRIORITY, SERVICE_PRIORITY, Dag
 from tdp.core.operation import Operation
 
 
-# TODO: Transform this to a script as it is not really a command (see #346).
-@click.command(
-    short_help="Generate meta playbooks in order to use a TDP like collection without tdp-lib"
-)
-@click.argument("services", required=False, nargs=-1)
-@click.option(
-    "--output-dir",
-    type=Path,
-    help="Output dir where playbooks will be written",
-    required=False,
-    default=".",
-)
-@click.option(
-    "--for-collection",
-    type=str,
-    help="Only write operation from this collection",
-    required=False,
-    multiple=True,
-)
-@collections
-def playbooks(services, output_dir, for_collection, collections):
+def playbooks(
+    collections: Collections,
+    *,
+    services: Optional[list[str]] = None,
+    output_dir: str = "meta",
+    for_collection: Optional[list[str]] = None,
+):
     dag = Dag(collections)
     # services DAG
     dag_services = nx.DiGraph()
@@ -50,12 +39,11 @@ def playbooks(services, output_dir, for_collection, collections):
     if not nx.is_directed_acyclic_graph(dag_services):
         raise RuntimeError("dag_services is not a DAG")
 
-    def custom_key(node):
+    def custom_key(node: str):
         operation_priority = SERVICE_PRIORITY.get(node, DEFAULT_SERVICE_PRIORITY)
         return f"{operation_priority:02d}_{node}"
 
     dag_services_order = nx.lexicographical_topological_sort(dag_services, custom_key)
-
     if services:
         services = set(services)
 
@@ -72,7 +60,10 @@ def custom_key(node):
         services = dag_services_order
 
     meta_dir = Path(output_dir, "meta")
-    meta_dir.mkdir()
+    if not meta_dir.is_dir():
+        meta_dir.mkdir()
+    else:
+        print("Folder meta already exists, will add extra services/collections if any")
 
     def write_copyright_licence_headers(fd):
         fd.write("# Copyright 2022 TOSIT.IO\n")
@@ -121,3 +112,51 @@ def write_copyright_licence_headers(fd):
                 )
             else:
                 all_fd.write(f"# {operation.name}\n")
+
+
+TDP_COLLECTION_PATH = os.environ.get("TDP_COLLECTION_PATH")
+
+if TDP_COLLECTION_PATH is not None:
+    if ":" in TDP_COLLECTION_PATH:
+        TDP_COLLECTION_PATH = [
+            TDP_COLLECTION_PATH.split(":", 1)[0],
+            TDP_COLLECTION_PATH.split(":", 1)[1]
+        ]
+
+parser = argparse.ArgumentParser()
+parser.add_argument(
+    "--collection",
+    action="append",
+    default=TDP_COLLECTION_PATH,
+    help="Folder path of the Ansible collection",
+)
+parser.add_argument(
+    "services",
+    metavar="service",
+    nargs="*",
+    help="Name of the services example hive hbase",
+)
+parser.add_argument(
+    "--output-dir", default=".", help="Output dir where playbooks will be written"
+)
+parser.add_argument(
+    "--for_collection",
+    action="append",
+    default=[],
+    help="Only write operation from this collection, specify the collection name",
+)
+args = parser.parse_args()
+services = args.services
+output_dir = args.output_dir
+for_collection = args.for_collection
+collections = Collections.from_collection_list(
+    [Collection.from_path(col) for col in args.collection]
+)
+
+if __name__ == "__main__":
+    playbooks(
+        collections,
+        services=services,
+        output_dir=output_dir,
+        for_collection=for_collection,
+    )

tdp/cli/__main__.py

@@ -15,7 +15,6 @@
 from tdp.cli.commands.init import init
 from tdp.cli.commands.operations import operations
 from tdp.cli.commands.plan import plan
-from tdp.cli.commands.playbooks import playbooks
 from tdp.cli.commands.status import status
 from tdp.cli.commands.validate import validate
 from tdp.cli.commands.vars import vars
@@ -64,7 +63,6 @@ def main():
     cli.add_command(init)
     cli.add_command(operations)
     cli.add_command(plan)
-    cli.add_command(playbooks)
     cli.add_command(status)
     cli.add_command(validate)
     cli.add_command(vars)