Plant trial export download #685
Conversation
| @@ -16,13 +18,29 @@ def show | |||
| end | |||
| render json: grid_data | |||
| end | |||
| format.zip do | |||
| exporter = Submission::PlantTrialExporter.new( | |||
There was a problem hiding this comment.
I'd prefer to put lines 22:32 into a new class like Submission::PlantTrialZipExport.
| to match_array [ts2.score_value, '-'] | ||
| expect(documents[:trait_scoring].lines[1,2].map{ |l| l.strip.split(',')[3] }). | ||
| to match_array [ts3.score_value, '-'] | ||
| expect(generated_scores.map{ |l| l[0] }).to match_array [ts1.score_value, '-', '-'] |
There was a problem hiding this comment.
I got the impression that order of scores should be important here, shouldn't it?
|
@kammerer Both comments addressed. Please go ahead with the review. |
|
👍 |
|
@kammerer Tomasz, I have added one more commit - to make the CSV headers consistent with the Browse section naming, and also removed two useless columns in one of the documents. Please see the commit and check if I should change anything. |
|
I'll go ahead and merge-deploy that since time is short and we want the client's feedback. Meanwhile I'll leave the branch so any further changes could be made on it. |
|
Note to self:
|
|
Moved all changes to #692 |
Fixes #683 #684 #690. Partially addresses #680 #639.