feat: gno ghverify agent #1288
Open
feat: gno ghverify agent #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
from
4db95bf to
10a9bf1
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
2 times, most recently
from
051b7cf to
207407a
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
2 times, most recently
from
0cbe6ef to
e29c5e4
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
from
e29c5e4 to
472bf06
Compare
Collaborator
|
maybe we should move that to a new repo? if we keep it here pls move it to |
hthieu1110
reviewed
Oct 15, 2024
gno_github_agent/.env
Outdated
| @@ -0,0 +1,5 @@ | |||
| GNO_MNEMONIC=source bonus chronic canvas draft south burst lottery vacant surface solve popular case indicate oppose farm nothing bullet exhibit title speed wink action roast | |||
Collaborator
There was a problem hiding this comment.
Is this normal that we keep this mnemonic here ?
hthieu1110
reviewed
Oct 15, 2024
| err := client.db.Model(&db.Verification{}).Where("status = ?", string(db.VerificationStatusVerified)).Order("id desc").First(&verification).Error | ||
|
|
||
| if err != nil { | ||
| if errors.Is(err, gorm.ErrRecordNotFound) { |
Collaborator
There was a problem hiding this comment.
I dont see the purpose if this error checking :o both cases return the same value
hthieu1110
reviewed
Oct 15, 2024
gno_github_agent/clientql/client.go
Outdated
| if attr.Key == "handle" { | ||
| handle = attr.Value | ||
| } | ||
| if attr.Key == "from" { |
Collaborator
There was a problem hiding this comment.
we should use else if to prevent one more unused comparison
Collaborator
Author
I think we should indeed move it to his own repository, I'll do as soon as this PR is approuved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.