fix: undefined member access on group actions and hide left members from chat list #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sachin-into
changed the title
sachin-into
changed the title
omniwired
reviewed
Apr 5, 2024
| data={searchResults.filter((result) => { | ||
| if ( | ||
| result?.type === "group" && | ||
| (!result?.members || result?.members.filter(Boolean).length === 0) // Hiding conversation from left member of the group |
There was a problem hiding this comment.
Wow, quite complex logic
There was a problem hiding this comment.
when user leave group, got members array with single 'undefined' element so filtered it out.
There was a problem hiding this comment.
better fix at root of problem
weshd/go/shared/shared.go
Outdated
| @@ -168,7 +168,6 @@ func StartHTTPServer() { | |||
|
|
|||
| if err := httpServer.ListenAndServe(); err != nil { | |||
| log.Println("weshnet: http listenAndServer err", err) | |||
| panic(errors.Wrap(err, "failed to start http server")) | |||
There was a problem hiding this comment.
Isn't this still required or at least a good idea to have?
There was a problem hiding this comment.
it's good to have but having it crashed app when disabling chat via toggle switch on android
sachin-into
force-pushed
the
fix/group-chat
branch
from
3c88a45
to
2cfdadc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependent on PR #1167
fix #1192