-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Continue to define Visibility class API #62
Conversation
Co-authored-by: DanRyanIrish <[email protected]>
Make underlying data structure for Visibilities class an xarray
Update Vis class PR
Update Vis_class PR (Part 2)
Co-authored-by: DanRyanIrish <[email protected]>
…n to level of class.
…lude optional metadata, rather than top level kwargs. Also add instrument attribute to VisMeta.
Thanks for the review @paolomassa. It makes no difference whether the units are defined as arcsec or deg. It just matters that the unit given bad user can be converted to the defined unit. It doesn't mean the value is actually converted to that unit. However, we should probably be consistent throughout the API and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank this looks good, no blockers, few small issues and the tests for the Meta side of things are on the low side.
Co-authored-by: Shane Maloney <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 89.26%
=======================================
Files ? 7
Lines ? 829
Branches ? 0
=======================================
Hits ? 740
Misses ? 89
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This PR carries on from #55 in refining the API of a new
Visibilities
object. Do not merge until #55 is merged.